[5.4] Passwort reset request: fix legend #46454
Open
+9
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Contributor
|
Same can you do at: |
Contributor
|
I have tested this item ✅ successfully on 0510135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
1 similar comment
Contributor
|
I have tested this item ✅ successfully on 0510135 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
richard67
reviewed
Nov 20, 2025
Member
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/46454. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #46446 .
Replaces #46451
Summary of Changes
This PR sepaprates Legend of the fieldset and label of a field in all pages for password reset. (request, confirm, complete)
Testing Instructions
I a frontend login form click the "forgot password" link.
Actual result BEFORE applying this Pull Request
The label of the fieldset is used for a legend. If there is no label, there would not be a legend at all, which is an a11y issue.
A legend is not an instruction but summarises the content of a fieldset.
This PR adds a legend for the fieldset, if there is a label or not.
Note:
If this is accepted, same change is needed for similiar pages in the users component.
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed